linux-kernel - Re: [PATCH 4.4 020/115] userfaultfd: selftest: vm: allow to build in vm/ directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180113102143.GA7558@kroah.com>
Date:   Sat, 13 Jan 2018 11:21:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Andrea Arcangeli <aarcange@...hat.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        "Dr. David Alan Gilbert" <dgilbert@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Pavel Emelyanov <xemul@...allels.com>,
        Hillf Danton <hillf.zj@...baba-inc.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sasha Levin <alexander.levin@...izon.com>
Subject: Re: [PATCH 4.4 020/115] userfaultfd: selftest: vm: allow to build in
 vm/ directory

On Thu, Jan 11, 2018 at 07:42:48PM +0000, Ben Hutchings wrote:
> On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Andrea Arcangeli <aarcange@...hat.com>
> > 
> > 
> > [ Upstream commit 46aa6a302b53f543f8e8b8e1714dc5e449ad36a6 ]
> > 
> > linux/tools/testing/selftests/vm $ make
> > 
> >   gcc -Wall -I ../../../../usr/include     compaction_test.c -lrt -o /compaction_test
> >   /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/../../../../x86_64-pc-linux-gnu/bin/ld: cannot open output file /compaction_test: Permission denied
> >   collect2: error: ld returned 1 exit status
> >   make: *** [../lib.mk:54: /compaction_test] Error 1
> > 
> > Since commit a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> > selftests/vm build fails if run from the "selftests/vm" directory, but
> > it works in the selftests/ directory.  It's quicker to be able to do a
> > local vm-only build after a tree wipe and this patch allows for it
> > again.
> 
> That commit is not included in 4.4 and nothing under
> tools/testing/selftests uses the OUTPUT variable that this defines.

Ugh, good catch, I'll go revert this.

Sasha, I thought your scripts caught this type of thing?

thanks,

greg k-h