linux-kernel - Re: [PATCH] [net-next] net: netsec: use dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Jan 2018 12:00:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jaswinder.singh@...aro.org, ard.biesheuvel@...aro.org,
        weiyongjun1@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] net: netsec: use dma_addr_t for storing dma
 address

From: Arnd Bergmann <arnd@...db.de>
Date: Sat, 13 Jan 2018 22:13:44 +0100

> On targets that have different sizes for phys_addr_t and dma_addr_t,
> we get a type mismatch error:
> 
> drivers/net/ethernet/socionext/netsec.c: In function 'netsec_alloc_dring':
> drivers/net/ethernet/socionext/netsec.c:970:9: error: passing argument 3 of 'dma_zalloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> The code is otherwise correct, as the address is never actually used as a
> physical address but only passed into a DMA register.  For consistently,
> I'm changing the variable name as well, to clarify that this is a DMA
> address.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.