linux-kernel - [tip:x86/timers] x86/time: Unconditionally register legacy timer interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-6d671e1b85c63e7a337ba76c1a154c091545cff8@git.kernel.org>
Date:   Sun, 14 Jan 2018 11:22:19 -0800
From:   tip-bot for Peter Zijlstra <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     peterz@...radead.org, hpa@...or.com, mingo@...nel.org,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [tip:x86/timers] x86/time: Unconditionally register legacy timer
 interrupt

Commit-ID:  6d671e1b85c63e7a337ba76c1a154c091545cff8
Gitweb:     https://git.kernel.org/tip/6d671e1b85c63e7a337ba76c1a154c091545cff8
Author:     Peter Zijlstra <peterz@...radead.org>
AuthorDate: Fri, 22 Dec 2017 10:20:12 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sun, 14 Jan 2018 20:18:23 +0100

x86/time: Unconditionally register legacy timer interrupt

Even without a PIC/PIT the legacy timer interrupt is required for HPET in
legacy replacement mode.

Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: len.brown@...el.com
Cc: rui.zhang@...el.com
Link: https://lkml.kernel.org/r/20171222092243.382623763@infradead.org

---
 arch/x86/kernel/time.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index 749d189..774ebaf 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -69,9 +69,12 @@ static struct irqaction irq0  = {
 
 static void __init setup_default_timer_irq(void)
 {
-	if (!nr_legacy_irqs())
-		return;
-	setup_irq(0, &irq0);
+	/*
+	 * Unconditionally register the legacy timer; even without legacy
+	 * PIC/PIT we need this for the HPET0 in legacy replacement mode.
+	 */
+	if (setup_irq(0, &irq0))
+		pr_info("Failed to register legacy timer interrupt\n");
 }
 
 /* Default timer init function */