[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJeuY7-FeiEtSkg=udnEx_==3SS=dinyk7fKqhLwdXcKE3510g@mail.gmail.com>
Date: Sun, 14 Jan 2018 15:07:46 +0800
From: Hao Zhang <hao5781286@...il.com>
To: Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc: Thierry Reding <thierry.reding@...il.com>, robh+dt@...nel.org,
Mark Rutland <mark.rutland@....com>, linux@...linux.org.uk,
Chen-Yu Tsai <wens@...e.org>,
Linus Walleij <linus.walleij@...aro.org>,
linux-gpio@...r.kernel.org,
open list <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@...ts.infradead.org>, linux-pwm@...r.kernel.org
Subject: Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.
2018-01-11 20:47 GMT+08:00 Maxime Ripard <maxime.ripard@...e-electrons.com>:
> Hi,
>
> On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
>> This patch add pwm pins for r40.
>>
>> Signed-off-by: hao_zhang <hao5781286@...il.com>
>
> You should order your patches differently. We try to be as bisectable
> as possible, and if we just apply this patch the DT will not compile
> anymore.
>
> Your patch 4 should come before this one.
>
Do you mean that the order of patch be applied is from the first to
the last in the patch set ?
because you apply the last patch first also break the DT compile...
Thinks :)
Hao Zhang
> Your commit title and log doesn't seem to match the content of the
> patch either.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
Powered by blists - more mailing lists