linux-kernel - Re: [tip:timers/urgent] timers: Unconditionally check deferrable base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180114224415.GX9671@linux.vnet.ibm.com>
Date:   Sun, 14 Jan 2018 14:44:15 -0800
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     bigeasy@...utronix.de, fweisbec@...il.com,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        mingo@...nel.org, tglx@...utronix.de, anna-maria@...utronix.de
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] timers: Unconditionally check deferrable base

On Sun, Jan 14, 2018 at 02:31:07PM -0800, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  ed4bbf7910b28ce3c691aef28d245585eaabda06
> Gitweb:     https://git.kernel.org/tip/ed4bbf7910b28ce3c691aef28d245585eaabda06
> Author:     Thomas Gleixner <tglx@...utronix.de>
> AuthorDate: Sun, 14 Jan 2018 23:19:49 +0100
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Sun, 14 Jan 2018 23:25:33 +0100
> 
> timers: Unconditionally check deferrable base
> 
> When the timer base is checked for expired timers then the deferrable base
> must be checked as well. This was missed when making the deferrable base
> independent of base::nohz_active.

Very cool, thank you!  I have fired up some of the dreaded TREE01 tests.

							Thanx, Paul

> Fixes: ced6d5c11d3e ("timers: Use deferrable base independent of base::nohz_active")
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Anna-Maria Gleixner <anna-maria@...utronix.de>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Sebastian Siewior <bigeasy@...utronix.de>
> Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: stable@...r.kernel.org
> Cc: rt@...utronix.de
> ---
>  kernel/time/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/timer.c b/kernel/time/timer.c
> index 89a9e1b..0bcf00e 100644
> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -1696,7 +1696,7 @@ void run_local_timers(void)
>  	hrtimer_run_queues();
>  	/* Raise the softirq only if required. */
>  	if (time_before(jiffies, base->clk)) {
> -		if (!IS_ENABLED(CONFIG_NO_HZ_COMMON) || !base->nohz_active)
> +		if (!IS_ENABLED(CONFIG_NO_HZ_COMMON))
>  			return;
>  		/* CPU is awake, so check the deferrable base. */
>  		base++;
>