linux-kernel - Re: [PATCH] nvme-pci: calculate iod and avg_seg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2b12a6e-c54a-c17b-4749-287633298af6@grimberg.me>
Date:   Sun, 14 Jan 2018 11:28:23 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Keith Busch <keith.busch@...el.com>,
        Jianchao Wang <jianchao.w.wang@...cle.com>
Cc:     axboe@...com, hch@....de, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: calculate iod and avg_seg_size just before use
 them


>> The calculation of iod and avg_seg_size maybe meaningless if
>> nvme_pci_use_sgls returns before uses them. So calculate
>> just before use them.
> 
> The compiler will do the right thing here, but I see what you mean. I
> think Christoph has some SGL improvements coming, though, that will
> obviate this.

I think that if its not coming for 4.16, it should be easy enough to
take it in.

FWIW,

Reviewed-by: Sagi Grimberg <sagi@...mberg.me>