linux-kernel - Re: [RESEND, 1/4] i2c: mpc: get MPC8xxx I2C clock prescaler before using it in calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115182145.vfic2xo6cyx5etl5@ninjato>
Date:   Mon, 15 Jan 2018 19:21:45 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Arseny Solokha <asolokha@...kras.ru>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Valentin Longchamp <valentin.longchamp@...mile.com>
Subject: Re: [RESEND, 1/4] i2c: mpc: get MPC8xxx I2C clock prescaler before
 using it in calculations

On Sat, Dec 30, 2017 at 07:18:14PM +0100, Wolfram Sang wrote:
> On Thu, Dec 07, 2017 at 05:20:00PM +0700, Arseny Solokha wrote:
> > Obtaining the actual I2C clock prescaler value in mpc_i2c_setup_8xxx() only
> > happens when the clock parameter is set to something other than
> > MPC_I2C_CLOCK_LEGACY. When the clock parameter is exactly
> > MPC_I2C_CLOCK_LEGACY, the prescaler parameter is used in arithmetic
> > division as provided by the caller, resulting in a division by zero
> > for the majority of processors supported by the module.
> > 
> > Avoid division by zero by obtaining the actual I2C clock prescaler
> > in mpc_i2c_setup_8xxx() unconditionally regardless of the passed clock
> > value.
> > 
> > Signed-off-by: Arseny Solokha <asolokha@...kras.ru>
> 
> Applied to for-current, thanks!

Reconsidered and moved to for-next.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)