linux-kernel - Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 20:33:42 +0100
From:   Ladislav Michl <ladis@...ux-mips.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-omap@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        Roger Quadros <rogerq@...com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: mfd/omap-usb-tll: Allocate driver data at once in
 usbtll_omap_probe()

On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote:
> >  		dev_dbg(dev,
> >  		 "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
> > -			ver, tll->nch);
> > +			ver, nch);
> >  		break;
> 
> Does this format string need an other indentation when you touch this statement?

Well, lets that the chance and make it shorter as well:

 	default:
-		tll->nch = OMAP_TLL_CHANNEL_COUNT;
-		dev_dbg(dev,
-		 "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
-			ver, tll->nch);
+		nch = OMAP_TLL_CHANNEL_COUNT;
+		dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n",
+			ver, nch);
 		break;

Other proposals?