linux-kernel - Re: [PATCH] Documentation: i2c: drop unnecessary .owner field in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeamZDS=-bwGYn41y0pwKEptRE02W3bRe326Q34i68=yg@mail.gmail.com>
Date:   Mon, 15 Jan 2018 22:24:52 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>, Jonathan Corbet <corbet@....net>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nicholas Mc Guire <hofrat@...dl.at>
Subject: Re: [PATCH] Documentation: i2c: drop unnecessary .owner field in examples

On Mon, Jan 15, 2018 at 2:08 PM, Nicholas Mc Guire <hofrat@...dl.org> wrote:
> From: Nicholas Mc Guire <hofrat@...dl.at>
>
>  Currently there are a few drivers that still set the .owner
>  in the i2c_driver structure - all of which are reported by
>  coccinelle (scripts/coccinelle/api/platform_no_drv_owner.cocci)
>  and there are no cases that set the .onwer and do not call any
>  of the functions that set the .owner field anyway in any of the
>  drivers (checked by a modified coccinelle script based on the
>  above) so it seems that the examples are no longer valid and
>  .owner = THIS_MODULE, can be removed here.
>
>  While at it an obvious typo (new new) was also fixed.

AFAIU It is right only in case when someone does this, e.g.
module_i2c_driver() macro. Otherwise the field is pretty valid and
must be filled.


-- 
With Best Regards,
Andy Shevchenko