linux-kernel - Re: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180115204229.GA11094@fury>
Date:   Mon, 15 Jan 2018 12:42:29 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] platform/x86: have ACPI_CMPC use depends instead of
 select for INPUT

On Sun, Jan 14, 2018 at 09:11:18PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
> 
> This also makes all platform/x86/ drivers consistent w.r.t depending on
> INPUT instead of selecting it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andy Shevchenko <andy@...radead.org>
> Cc: platform-driver-x86@...r.kernel.org

Thanks Randy, queued.

-- 
Darren Hart
VMware Open Source Technology Center