linux-kernel - Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 10:38:06 +0000
From:   James Morse <james.morse@....com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Catalin Marinas <catalin.marinas@....com>
CC:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] firmware: arm_sdei: Fix return value check in sdei_present_dt()

Hi Wei,

On 15/01/18 10:41, Wei Yongjun wrote:
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.

Bother, so it does!

Thanks for catching this.
Acked-by: James Morse <james.morse@....com>


Thanks,

James