linux-kernel - Re: [PATCH] s390: fix setgid16/setuid16 handling of -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115120652.GA16218@kroah.com>
Date:   Mon, 15 Jan 2018 13:06:52 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     linux-s390@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: fix setgid16/setuid16 handling of -1

On Mon, Jan 15, 2018 at 12:52:42PM +0100, Eugene Syromiatnikov wrote:
> For some reason, the implementation of these two 16-bit ID system calls
> used cast instead of low2highgid/low2highuid macros for converting [GU]IDs,
> which leads to incorrect handling of value of -1 (which ought to be
> considered invalid).
> 
> Discovered by strace test suite.
> 
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> ---
>  arch/s390/kernel/compat_linux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Care to add a cc: stable on this?

thanks,

greg k-h