linux-kernel - Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516021268.22147.156.camel@infradead.org>
Date:   Mon, 15 Jan 2018 14:01:08 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     "Van De Ven, Arjan" <arjan.van.de.ven@...el.com>,
        David Laight <David.Laight@...LAB.COM>,
        'Andi Kleen' <andi@...stfloor.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>
Cc:     "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        "jeyu@...nel.org" <jeyu@...nel.org>
Subject: Re: [PATCH] retpoline/module: Taint kernel for missing retpoline
 in module

On Mon, 2018-01-15 at 12:53 +0000, Van De Ven, Arjan wrote:
> 
> binary what? ;-)
> 
> retpoline (or lack thereof) is part of the kernel ABI at this point.... 

Strictly speaking, only lack thereof.

If you build the kernel without CONFIG_RETPOLINE, you can't build
modules with retpoline and then expect them to load — because the thunk
symbols aren't exported.

If you build the kernel with the retpoline though, you *can*
successfully load modules which aren't built with retpoline.

It's not even that unlikely, if the kernel engineers are ensuring they
have the latest unreleased toolchain for kernel builds, but you're
using out-of-tree modules built separately or even on the target system
using DKMS, and you *haven't* got the shiny new compiler.

That's what Andi's attempting to protect against.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)