linux-kernel - Re: [PATCH] tools/lib/traceevent/event-parse: delete pevent_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 10:13:35 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, Wang YanQing <udknight@...il.com>,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/lib/traceevent/event-parse: delete
 pevent_register_function

Em Mon, Jan 15, 2018 at 06:54:27AM -0500, Steven Rostedt escreveu:
> On Mon, 15 Jan 2018 11:08:34 +0100
> Jiri Olsa <jolsa@...hat.com> wrote:
> 
> > On Mon, Jan 15, 2018 at 12:50:14PM +0800, Wang YanQing wrote:
> > > After commit 4263cece22e3da94f16fbbcf71ce3807946d3ef3
> > > ("perf tools: Stop reading the kallsyms data from perf.data"),
> > > there is no users of pevent_register_function in tree, so we
> > > could just delete it.
> > >   
> > 
> > I don't think you can remove this function,
> > perf is not the only user there
> 
> Correct. The tools/lib does not have the same requirements as the
> kernel code. It's purpose is to be a library for other tools, not just
> what is in tree. Otherwise, I would be happy to add trace-cmd to the
> kernel proper, as that is where this code originated from.
> 
> Don't delete those functions. They are required elsewhere.

Right, I'll eventually add a 'perf test' entry to use those functions,
testing its functionality so that this doesn't resurfaces in the future
:-)

- Arnaldo