linux-kernel - [PATCH] staging: unisys: change select to depends for subsystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Jan 2018 21:10:54 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     David Kershner <david.kershner@...sys.com>,
        sparmaintainer@...sys.com, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] staging: unisys: change select to depends for subsystems

From: Randy Dunlap <rdunlap@...radead.org>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: David Kershner <david.kershner@...sys.com>
Cc: sparmaintainer@...sys.com (Unisys internal)
Cc: devel@...verdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/staging/unisys/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
 menuconfig UNISYSSPAR
 	bool "Unisys SPAR driver support"
 	depends on X86_64 && !UML
-	select PCI
-	select ACPI
+	depends on PCI && ACPI
 	---help---
 	Support for the Unisys SPAR drivers