[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <5A5C3DB1.5080604@samsung.com>
Date: Mon, 15 Jan 2018 14:35:45 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Hans de Goede <hdegoede@...hat.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Chen-Yu Tsai <wens@...e.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] extcon: axp288: Constify the
axp288_pwr_up_down_info array
On 2018년 01월 15일 00:10, Hans de Goede wrote:
> Make the axp288_pwr_up_down_info array const char * const, this leads
> to the following section size changes:
>
> .text 0x674 -> 0x664
> .data 0x148 -> 0x0f0
> .rodata 0x0b4 -> 0x114
>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
> drivers/extcon/extcon-axp288.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 081d8a1b4fd7..63b99d5becd7 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -118,7 +118,7 @@ static const struct x86_cpu_id cherry_trail_cpu_ids[] = {
> };
>
> /* Power up/down reason string array */
> -static char *axp288_pwr_up_down_info[] = {
> +static const char * const axp288_pwr_up_down_info[] = {
> "Last wake caused by user pressing the power button",
> "Last wake caused by a charger insertion",
> "Last wake caused by a battery insertion",
> @@ -136,7 +136,7 @@ static char *axp288_pwr_up_down_info[] = {
> */
> static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
> {
> - char **rsi;
> + const char * const *rsi;
> unsigned int val, i, clear_mask = 0;
> int ret;
>
>
Applied it to v4.17
because I had finished the extcon pull request for v4.16.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Powered by blists - more mailing lists