[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1801151457080.3305@hadrien>
Date: Mon, 15 Jan 2018 14:58:25 +0100 (CET)
From: Julia Lawall <julia.lawall@...6.fr>
To: Thierry Reding <thierry.reding@...il.com>
cc: Thierry Reding <treding@...dia.com>,
David Airlie <airlied@...ux.ie>, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
kbuild-all@...org, Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings
On Mon, 15 Jan 2018, Thierry Reding wrote:
> On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote:
> > From: Fengguang Wu <fengguang.wu@...el.com>
> >
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> > drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> > ---
> >
> > tree: https://github.com/thierryreding/linux for-4.16/work
> > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4
> > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP
> >
> > nouveau_gem.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Hi Julia,
>
> thanks for the patch. However, the tree that you generated it against is
> a personal development tree and it happens to have a bunch of commits in
> it that are very experimental and some of which are very unlikely to go
> upstream. There's an IOCTL addition patch (touched by hunk 7 in this
> patch) that is used only for testing purposes. All of the other hunks do
> pply properly to linux-next, so I think those can be posted. Nouveau is
> maintained by Ben Skeggs, though, so they should be addressed to him.
>
> I don't personally mind getting these patches, and I don't mind people
> seeing the personal development tree (it's publicly available, after
> all) but I think patches against this tree will be confusing to anyone
> but me because they are likely not going to apply anywhere other than
> that tree.
OK, I'm just forwarding what kbuild sends me for approval. No problem if
you toss it, apply it, or do whatever seems reasonable :)
julia
>
> Thanks,
> Thierry
>
Powered by blists - more mailing lists