linux-kernel - Re: [PATCH 2/2] soc: bcm: brcmstb: Be multi-platform compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1H1y_f2M9a0F_CcsCgfx8Y2T=MHH9K+4=YqVN3_fB4wA@mail.gmail.com>
Date:   Mon, 15 Jan 2018 15:47:40 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     arm-soc <arm@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Thierry Reding <treding@...dia.com>,
        Brian Norris <computersforpeace@...il.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] soc: bcm: brcmstb: Be multi-platform compatible

On Fri, Jan 12, 2018 at 10:08 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> From: Thierry Reding <treding@...dia.com>
>
> We were making a bunch of wrong assumptions that turned out to blow out
> on non-Broadcom STB platforms:
>
> - we would return -ENODEV from brcmstb_soc_device_early_init() if we
>   could not find the sun_top_ctrl device node, this is not an error
>   in the context of a multi-platform kernel
> - we would still try to register the Broadcom STB SoC device, even if we
>   are not running on such a platform
>
> While at it, also fix the sun_top_ctrl device_node leaks while we change
> the flow of brcmstb_soc_device_init() and
> brcmstb_soc_device_early_init().
>
> Fixes: f780429adfbc ("soc: brcmstb: biuctrl: Move to early_initcall")
> Signed-off-by: Thierry Reding <treding@...dia.com>
> [florian: Combine all of Thierry's patch in one go for easier review]
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied both to next/drivers, thanks!

         Arnd