linux-kernel - Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <6b9d8164-a2cf-8449-ad97-6331494d8427@linux.vnet.ibm.com>
Date:   Mon, 15 Jan 2018 09:24:25 -0600
From:   Eddie James <eajames@...ux.vnet.ibm.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     arnd@...db.de, jdelvare@...e.com, sam@...dozajonas.com,
        Andrew Jeffery <andrew@...id.au>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS


On Fri, Jan 12, 2018 at 06:19:00PM +0100, Guenter Roeck wrote:
> On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> > Building without CONFIG_LEDS_CLASS causes a link failure:
> >
> > drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> > ibm-cffps.c:(.text+0x4f4): undefined reference to 
> `devm_of_led_classdev_register'
> >
> > This adds the required dependency.
> >
> > Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor 
> (CFF) power supply driver")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I wanted to let Edward decide if he wants the new dependency or 
> conditional code
> in the driver. Not having heard from him, I'll take your patch instead 
> for now.

Thanks, yes this is a good solution for this driver. Didn't think about 
that during testing... Thanks Arnd.

Eddie

>
> Thanks,
> Guenter
>
> > ---
> >  drivers/hwmon/pmbus/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> > index 08479006c7f9..6e4298e99222 100644
> > --- a/drivers/hwmon/pmbus/Kconfig
> > +++ b/drivers/hwmon/pmbus/Kconfig
> > @@ -39,6 +39,7 @@ config SENSORS_ADM1275
> >
> >  config SENSORS_IBM_CFFPS
> >   tristate "IBM Common Form Factor Power Supply"
> > + depends on LEDS_CLASS
> >   help
> >    If you say yes here you get hardware monitoring support for the IBM
> >    Common Form Factor power supply.
> > --
> > 2.9.0
> >
>