linux-kernel - Re: [PATCH] blk_rq_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0241d415-dc04-110a-771f-c245d963fec0@kernel.dk>
Date:   Mon, 15 Jan 2018 08:50:53 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Douglas Gilbert <dgilbert@...erlog.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Cc:     bart.vanassche@....com, dvyukov@...gle.com
Subject: Re: [PATCH] blk_rq_map_user_iov: fix error override

On 1/14/18 3:00 PM, Douglas Gilbert wrote:
> During stress tests by syzkaller on the sg driver the block layer
> infrequently returns EINVAL. Closer inspection shows the block
> layer was trying to return ENOMEM (which is much more
> understandable) but for some reason overroad that useful error.
> 
> Patch below does not show this (unchanged) line:
>    ret =__blk_rq_map_user_iov(rq, map_data, &i, gfp_mask, copy);
> That 'ret' was being overridden when that function failed.

Thanks, applied.

-- 
Jens Axboe