linux-kernel - RE: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for free running counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0775380073F@SHSMSX103.ccr.corp.intel.com>
Date:   Mon, 15 Jan 2018 15:53:24 +0000
From:   "Liang, Kan" <kan.liang@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "acme@...nel.org" <acme@...nel.org>,
        "eranian@...gle.com" <eranian@...gle.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>
Subject: RE: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for
 free running counter

> On Thu, 2 Nov 2017, kan.liang@...el.com wrote:
> 
> > From: Kan Liang <Kan.liang@...el.com>
> >
> > The free running counter is read-only and always active. Current generic
> > uncore code does not support this kind of counters.
> >
> > The free running counter is read-only. It cannot be enable/disable in
> > event_start/stop.
> > The free running counter event and free running counter are 1:1 mapped.
> > It doesn't need to be assigned nor tracked by event_list.
> > The free running counters are always active. It doesn't need to check
> > the free running counters' availability.
> >
> > Use inline helpers to check fixed counter index and free running counter
> > index.
> >
> 
> That changelog is horrible to read. Other than that:
>

Hi Thomas,

Thanks for your review.

Sorry about the changelog.
I will modify the changelog and resend all the patches.

Thanks,
Kan
 
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>