linux-kernel - Re: [PATCH v5 2/2] printk: Hide console waiter logic into helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115160820.vsn7wyejlp2f654s@pathway.suse.cz>
Date:   Mon, 15 Jan 2018 17:08:20 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        rostedt@...e.goodmis.org, Byungchul Park <byungchul.park@....com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Tejun Heo <tj@...nel.org>, Pavel Machek <pavel@....cz>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] printk: Hide console waiter logic into helpers

On Fri 2018-01-12 11:36:27, Steven Rostedt wrote:
> On Fri, 12 Jan 2018 17:08:37 +0100
> Petr Mladek <pmladek@...e.com> wrote:
> > >From f67f70d910d9cf310a7bc73e97bf14097d31b059 Mon Sep 17 00:00:00 2001  
> > From: Petr Mladek <pmladek@...e.com>
> > Date: Fri, 22 Dec 2017 18:58:46 +0100
> > Subject: [PATCH v6 2/4] printk: Hide console waiter logic into helpers
> > 
> > The commit ("printk: Add console owner and waiter logic to load balance
> > console writes") made vprintk_emit() and console_unlock() even more
> > complicated.
> > 
> > This patch extracts the new code into 3 helper functions. They should
> > help to keep it rather self-contained. It will be easier to use and
> > maintain.
> > 
> > This patch just shuffles the existing code. It does not change
> > the functionality.
> > 
> Besides the typos (which should be fixed)...
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

JFYI, I have fixed the typos, updated the commit message for
the 1st patch and pushed all into printk.git,
branch for-4.16-console-waiter-logic, see
https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/log/?h=for-4.16-console-waiter-logic

I know that the discussion is not completely finished but it is
somehow cycling. Sergey few times wrote that he would not block
these patches. It is high time, I put it into linux-next. I could
always remove it if decided in the discussion.

Best Regards,
Petr