linux-kernel - Re: bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180116191536.7CF82602BA@smtp.codeaurora.org>
Date:   Tue, 16 Jan 2018 19:15:36 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Matt Redfearn <matt.redfearn@...tec.com>,
        James Hogan <jhogan@...nel.org>
Subject: Re: bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets

Guenter Roeck <linux@...ck-us.net> wrote:

> Mips builds with BCMA host mode enabled fail in mainline and -next
> with:
> 
> In file included from include/linux/bcma/bcma.h:10:0,
>                  from drivers/bcma/bcma_private.h:9,
> 		 from drivers/bcma/main.c:8:
> include/linux/bcma/bcma_driver_pci.h:218:24: error:
> 	field 'pci_controller' has incomplete type
> 
> Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS
> system type as generic") as the culprit. Analysis shows that the commmit
> changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
> disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
> defined if PCI_DRIVERS_LEGACY is enabled.
> 
> Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
> PCI_DRIVERS_LEGACY. Add the missing dependency.
> 
> Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...")
> Cc: Matt Redfearn <matt.redfearn@...tec.com>
> Cc: James Hogan <jhogan@...nel.org>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> Reviewed-by: James Hogan <jhogan@...nel.org>

Patch applied to wireless-drivers.git, thanks.

664eadd6f44b bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets

-- 
https://patchwork.kernel.org/patch/10162839/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches