linux-kernel - Re: [PATCH 2/5] perf unwind: Do not look at globals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116200705.GH16107@kernel.org>
Date:   Tue, 16 Jan 2018 17:07:05 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        David Ahern <dsahern@...il.com>,
        Hendrick Brueckner <brueckner@...ux.vnet.ibm.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Richter <tmricht@...ux.vnet.ibm.com>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 2/5] perf unwind: Do not look at globals

Em Tue, Jan 16, 2018 at 08:55:55PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 16, 2018 at 04:45:20PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 16, 2018 at 08:30:35PM +0100, Jiri Olsa escreveu:
> > > On Tue, Jan 16, 2018 at 12:36:21PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Tue, Jan 16, 2018 at 04:19:15PM +0100, Jiri Olsa escreveu:
> > > > > On Tue, Jan 16, 2018 at 11:24:35AM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > 
> > > > > SNIP
> > > > > 
> > > > > > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > > > > > Cc: David Ahern <dsahern@...il.com>
> > > > > > Cc: Hendrick Brueckner <brueckner@...ux.vnet.ibm.com>
> > > > > > Cc: Jiri Olsa <jolsa@...nel.org>
> > > > > > Cc: Namhyung Kim <namhyung@...nel.org>
> > > > > > Cc: Thomas Richter <tmricht@...ux.vnet.ibm.com>
> > > > > > Cc: Wang Nan <wangnan0@...wei.com>
> > > > > > Link: https://lkml.kernel.org/n/tip-skbth8ufepbtw8xar7gdsb6l@git.kernel.org
> > > > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > > > > > ---
> > > > > >  tools/perf/util/unwind-libunwind-local.c | 9 ---------
> > > > > >  1 file changed, 9 deletions(-)
> > > > > > 
> > > > > > diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> > > > > > index 7a42f703e858..02dc5a9d8f72 100644
> > > > > > --- a/tools/perf/util/unwind-libunwind-local.c
> > > > > > +++ b/tools/perf/util/unwind-libunwind-local.c
> > > > > > @@ -631,9 +631,6 @@ static unw_accessors_t accessors = {
> > > > > >  
> > > > > >  static int _unwind__prepare_access(struct thread *thread)
> > > > > >  {
> > > > > > -	if (callchain_param.record_mode != CALLCHAIN_DWARF)
> > > > > > -		return 0;
> > > > > > -
> > > > > 
> > > > > this would create thread->addr_space also for data without
> > > > > dwarf callchains data, so I think we need to keep it
> > > > > 
> > > > > it should get set in apply_config_terms which calls parse_callchain_record
> > > > 
> > > > No, it should not set the global parameter, as this is just for a
> > > > specific event, i.e. we can have something like:
> > > > 
> > > > 	perf record -e cycles/call-graph=dwarf/ \
> > > > 		    -e instructions/call-graph=lbr/
> > > > 		    -e cache-misses/call-graph=fp
> > > > 
> > > > And then get these samples for the same thread.
> > > > 
> > > > If you want to avoid creating thread->addr_space, and we do want that,
> > > > sure, a followup patch should address that, we need to postpone
> > > > allocating it till we get a DWARF callchain in a sample for that
> > > > specific thread, when we then should allocate thread->addr_space.
> > > 
> > > yea that could be fixed.. however current code prevents
> > > to create that for data without DWARF data, and your change
> > > forces it
> > 
> > Humm? Which code?
> 
> these bits

Those are replaced already, based on your comments.
 
> jirka
> 
> 
> ---
> diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> index 7a42f703e858..02dc5a9d8f72 100644
> --- a/tools/perf/util/unwind-libunwind-local.c
> +++ b/tools/perf/util/unwind-libunwind-local.c
> @@ -631,9 +631,6 @@ static unw_accessors_t accessors = {
> 
>  static int _unwind__prepare_access(struct thread *thread)
>  {
> -       if (callchain_param.record_mode != CALLCHAIN_DWARF)
> -               return 0;
> -
>         thread->addr_space = unw_create_addr_space(&accessors, 0);
>         if (!thread->addr_space) {
>                 pr_err("unwind: Can't create unwind address space.\n");
> @@ -646,17 +643,11 @@ static int _unwind__prepare_access(struct thread *thread)
> 
>  static void _unwind__flush_access(struct thread *thread)
>  {
> -       if (callchain_param.record_mode != CALLCHAIN_DWARF)
> -               return;
> -
>         unw_flush_cache(thread->addr_space, 0, 0);
>  }
> 
>  static void _unwind__finish_access(struct thread *thread)
>  {
> -       if (callchain_param.record_mode != CALLCHAIN_DWARF)
> -               return;
> -
>         unw_destroy_addr_space(thread->addr_space);
>  }