linux-kernel - Re: [PATCH RFC tip/core/rcu] Make SRCU be once again optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180116235703.GD9671@linux.vnet.ibm.com>
Date:   Tue, 16 Jan 2018 15:57:03 -0800
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Nicolas Pitre <nicolas.pitre@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH RFC tip/core/rcu] Make SRCU be once again optional

On Wed, Jan 17, 2018 at 12:03:18AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 11:55 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
> >
> > That fixed the first warning for me, doing the same thing for all three
> > fixed the rest
> 
> Now with my workaround applied and the original randconfig that triggered
> the failure, I get another problem:
> 
> drivers/base/power/wakeup.c:68:1: error: data definition has no type
> or storage class [-Werror]
>  DEFINE_STATIC_SRCU(wakeup_srcu);
> 
> Evidently there is at least one driver that uses SRCU but doesn't 'select SRCU'
> in Kconfig. There are probably others that just haven't been found.

Does adding "select SRCU" on "config PM_SLEEP" in kernel/power/Kconfig
fix this?

							Thanx, Paul