linux-kernel - Re: [PATCH v1 5/6] x86/boot: Allow longer parameter list for earlyprintk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116031123.35emo6eiqicbx67q@gmail.com>
Date:   Tue, 16 Jan 2018 04:11:23 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 5/6] x86/boot: Allow longer parameter list for
 earlyprintk


* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Allow longer parameter list for earlyprintk to support new coming
> parameters.
> 
> No functional change intended.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  arch/x86/boot/early_serial_console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> index 8cb7b0e8fe98..ef10926ab9e5 100644
> --- a/arch/x86/boot/early_serial_console.c
> +++ b/arch/x86/boot/early_serial_console.c
> @@ -90,7 +90,7 @@ static void early_serial_init(unsigned long port, int baud)
>  static void parse_earlyprintk(void)
>  {
>  	int baud = DEFAULT_BAUD;
> -	char arg[32];
> +	char arg[64];
>  	int pos = 0;
>  	unsigned long port = 0;

BTW., what happens if the parsed string is longer than this buffer?

Thanks,

	Ingo