linux-kernel - Re: [PATCH] soc: xilinx: xlnx_vcu: Depends on HAS_IOMEM for xlnx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <162bd4c1-6125-f856-85b1-6ee2d69ac7ec@xilinx.com>
Date:   Tue, 16 Jan 2018 08:35:26 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Dhaval Shah <dhaval.shah@...inx.com>, <michal.simek@...inx.com>,
        <pombredanne@...b.com>, <tglx@...utronix.de>,
        <kstewart@...uxfoundation.org>, <gregkh@...uxfoundation.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Dhaval Shah <dshah@...inx.com>
Subject: Re: [PATCH] soc: xilinx: xlnx_vcu: Depends on HAS_IOMEM for xlnx_vcu

On 16.1.2018 07:34, Dhaval Shah wrote:
> xlnx_vcu driver uses devm_ioremap_nocache, which is included
> only when HAS_IOMEM is enabled.
> 
> drivers/soc/xilinx/xlnx_vcu.o: In function `xvcu_probe':
>    xlnx_vcu.c:(.text+0x116): undefined reference to `devm_ioremap_nocache'
>    xlnx_vcu.c:(.text+0x1ae): undefined reference to `devm_ioremap_nocache'
> 
> Signed-off-by: Dhaval Shah <dshah@...inx.com>
> ---
>  drivers/soc/xilinx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/xilinx/Kconfig b/drivers/soc/xilinx/Kconfig
> index 266b50f..bf657ab 100644
> --- a/drivers/soc/xilinx/Kconfig
> +++ b/drivers/soc/xilinx/Kconfig
> @@ -3,6 +3,7 @@ menu "Xilinx SoC drivers"
>  
>  config XILINX_VCU
>          tristate "Xilinx VCU logicoreIP Init"
> +	depends on HAS_IOMEM
>          help
>            Provides the driver to enable and disable the isolation between the
>            processing system and programmable logic part by using the logicoreIP
> 


Applied.

Thanks,
Michal