linux-kernel - Re: [PATCH] mm: memory: fixed a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Jan 2018 08:46:56 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Robert Donald Rickett <robert.rickett@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: memory: fixed a coding style issue

On Mon 15-01-18 19:17:12, Robert Donald Rickett wrote:
> This is a patch to the memory.c file that fixes the
> "ERROR: code indent should use tabs where possible"
> found by the checkpatch.pl tool.

Is this really worth it? The code is not any better readable and it just
adds a churn to the history and makes life of anybody using git blame
slightly more harder. So what is the benefit?

> Signed-off-by: Robert Donald Rickett <robert.rickett@...il.com>
> ---
>  mm/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index ca5674cbaff2..e9f6e58aa77c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1663,7 +1663,7 @@ int zap_vma_ptes(struct vm_area_struct *vma, unsigned long address,
> 		unsigned long size)
>  {
> 	if (address < vma->vm_start || address + size > vma->vm_end ||
> -			!(vma->vm_flags & VM_PFNMAP))
> +			!(vma->vm_flags & VM_PFNMAP))
> 		return -1;
> 	zap_page_range_single(vma, address, size, NULL);
> 	return 0;
> --
> 2.14.1

-- 
Michal Hocko
SUSE Labs