linux-kernel - RE: [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR05MB3330579046971991B10D6C46A2EA0@AM4PR05MB3330.eurprd05.prod.outlook.com>
Date:   Tue, 16 Jan 2018 08:06:33 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Darren Hart <dvhart@...radead.org>
CC:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver
 for ARM architecture



> -----Original Message-----
> From: Darren Hart [mailto:dvhart@...radead.org]
> Sent: Tuesday, January 16, 2018 5:43 AM
> To: Vadim Pasternak <vadimp@...lanox.com>
> Cc: andy.shevchenko@...il.com; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org; platform-driver-x86@...r.kernel.org; jiri@...nulli.us
> Subject: Re: [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for
> ARM architecture
> 
> On Thu, Jan 11, 2018 at 08:58:42AM +0000, Vadim Pasternak wrote:
> > It allows driver to run on x86 and ARM architecture based systems.
> > Also some unnecessary includes are removed.
> 
> Hi Vadim,
> 
> These changes are not all readily mapped to this description, nor to the
> changelog below.
> 
> Only the kconfig change is obviously linked to building on ARM and not just x86.
> 
> Things like the removal of the dev_err messages and the relocation of the create
> and destroy methods seem entirely unrelated to building on ARM.
> 
> I'd like to get this merged sooner rather than later as it has been lingering for
> quite some time now - can you provide some more detail about how the
> changes included in this patch are needed to make this driver build on ARM?

Yes. Right.
Should I split it to two separate patches, one only with Kconfig changes and the
second with text like:
Remove some unnecessary includes;
Remove dev_err message;
Change filed bus to nr for consistency with kernel definitions;

> 
> Thanks,
> 
> --
> Darren Hart
> VMware Open Source Technology Center