linux-kernel - Re: [PATCH 1/2] objtool: Fix seg fault with gold linker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180116083017.4yb3ej67ll5m5m73@gmail.com>
Date:   Tue, 16 Jan 2018 09:30:17 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Markus <M4rkusXXL@....de>, Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/2] objtool: Fix seg fault with gold linker


* Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote:
> > 
> > * Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> > 
> > > Objtool seg faults when the gold linker is used with
> > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y.
> > > 
> > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before
> > > being passed to objtool.  The gold linker seems to strip unused ELF
> > > symbols by default, which confuses objtool and causes the seg fault when
> > > it's trying to generate ORC metadata.
> > 
> > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into 
> > a more useful failure message?
> 
> Good point.  I'll fix up this seg fault, and the other one
> found/introduced when adding retpoline support.

Thanks!

	Ingo