linux-kernel - Re: [PATCH v7 4/8] can: m_can: Move allocation of net device to probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <811c146c-7269-fb70-30bb-f60159473f02@ti.com>
Date:   Tue, 16 Jan 2018 14:33:08 +0530
From:   Faiz Abbas <faiz_abbas@...com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>, <wg@...ndegger.com>,
        <robh+dt@...nel.org>, <mark.rutland@....com>
CC:     <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <nsekhar@...com>, <fcooper@...com>, <robh@...nel.org>,
        <Wenyou.Yang@...rochip.com>, <sergei.shtylyov@...entembedded.com>,
        <linux-omap@...r.kernel.org>, <b29396@...escale.com>
Subject: Re: [PATCH v7 4/8] can: m_can: Move allocation of net device to probe

Hi,

On Monday 15 January 2018 07:22 PM, Marc Kleine-Budde wrote:
> On 01/10/2018 11:55 AM, Faiz Abbas wrote:
>> With the version no longer required to allocate the net device, it can
>> be moved to probe and the alloc_m_can_dev() function can be simplified.
>>
>> Therefore, move the allocation of net device to probe and change
>> alloc_m_can_dev() to setup_m_can_dev().
> 
> The error handling is broken with this patch,
> 
> Have a look at the switch (priv->version) in setup_m_can_dev(), you free
> the m_can_dev in case of error, but exit with -EINVAL in the beginning
> of the function. setup_m_can_dev() should not free if it doesn't allocate.
> 
> The error handling in m_can_plat_probe() is broken, too. If
> pm_runtime_get_sync(&pdev->dev) fails, you don't free the candev.
> 

Will fix.

Thanks,
Faiz