linux-kernel - Re: [PATCH v1 0/8] perf: Follow-up patches to improve time slice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <989a7dbf-c91c-fd0d-189d-5f9da007a68c@linux.intel.com>
Date:   Tue, 16 Jan 2018 20:31:09 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 0/8] perf: Follow-up patches to improve time slice



On 1/16/2018 7:55 PM, Jiri Olsa wrote:
> On Wed, Jan 10, 2018 at 11:00:25PM +0800, Jin Yao wrote:
>> It's follow-up patches to improve the perf time slice feature
>> (perf report/script --time xxx)
>>
>> 1. Improve the error message
>>     perf report: Improve error msg when no first/last sample time found
>>     perf script: Improve error msg when no first/last sample time found
>>
>> 2. Fix an issue that illegal percent was accepted previously (e.g. 1abc%)
>>     perf util: Improve error checking for time percent input
>>
>> 3. Omit the slice index if possible. For example,
>>     perf report --stdio --time 10%/1 is equivalent to
>>     perf report --stdio --time 10%
>>
>>     perf util: Support no index time percent slice
>>
>> 4. Add indication of time slices in perf report header.
>>     perf report: Add an indication of what time slices are used
>>
>> 5. Remove the time slices number limitation in perf report/script
>>     perf util: Allocate time slices buffer according to number of comma
>>     perf report: Remove the time slices number limitation
>>     perf script: Remove the time slices number limitation
>>
>> Jin Yao (8):
>>    perf report: Improve error msg when no first/last sample time found
>>    perf script: Improve error msg when no first/last sample time found
>>    perf util: Improve error checking for time percent input
>>    perf util: Support no index time percent slice
>>    perf report: Add an indication of what time slices are used
>>    perf util: Allocate time slices buffer according to number of comma
>>    perf report: Remove the time slices number limitation
>>    perf script: Remove the time slices number limitation
> 
> from quick look it looks ok
> 
> Reviewed-by: Jiri Olsa <jolsa@...hat.com>
> 
> thanks,
> jirka
> 

Hi Jiri,

Thanks so much for reviewing the patch.

Thanks
Jin Yao