[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1dcb2038-cc6d-44e5-fe51-e43041b1fe5f@pengutronix.de>
Date: Tue, 16 Jan 2018 15:00:25 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Faiz Abbas <faiz_abbas@...com>, wg@...ndegger.com,
robh+dt@...nel.org, mark.rutland@....com
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
nsekhar@...com, fcooper@...com, robh@...nel.org,
Wenyou.Yang@...rochip.com, sergei.shtylyov@...entembedded.com,
linux-omap@...r.kernel.org, b29396@...escale.com
Subject: Re: [PATCH v8 3/5] can: m_can: Move allocation of net device to probe
On 01/16/2018 02:03 PM, Marc Kleine-Budde wrote:
>> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
>> index 893edbb..ebb74de 100644
>> --- a/drivers/net/can/m_can/m_can.c
>> +++ b/drivers/net/can/m_can/m_can.c
>> @@ -1207,25 +1207,20 @@ static bool m_can_niso_supported(const struct m_can_priv *priv)
>> return !niso_timeout;
>> }
>>
>> -static struct net_device *alloc_m_can_dev(struct platform_device *pdev,
>> - void __iomem *addr, u32 tx_fifo_size)
>> +static int setup_m_can_dev(struct platform_device *pdev, struct net_device *dev,
>> + void __iomem *addr)
>
> Renamed to m_can_dev_setup() for consistent namespace.
And removed free_m_can_dev(), by calling free_candev() directly.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists