linux-kernel - Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180116141947.5fypmthkmb573jkp@linux-x5ow.site>
Date:   Tue, 16 Jan 2018 15:19:47 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Hannes Reinecke <hare@...e.de>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup_cmd

On Tue, Jan 16, 2018 at 12:27:33PM +0100, Hannes Reinecke wrote:
> In general I'd rather have the tracepoints when actually submitting the
> request; with this tracepoint we might be getting a trace which doesn't
> really indicate if the command was submitted at all.

yes but if we really want to be 100% certain we need to take the tracepoints
in either in blk_mq_dispatch_rq_list() and trace the return value of the respective
->queue_rq() or in the PCI/FC/RDMA drivers.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850