linux-kernel - Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jan 2018 16:13:12 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bogdan Purcareata <bogdan.purcareata@....com>
Cc:     laurentiu.tudor@....com, ruxandra.radulescu@....com,
        devel@...verdev.osuosl.org, robh@...nel.org, stuyoder@...il.com,
        arnd@...db.de, marc.zyngier@....com, roy.pledge@....com,
        ioana.ciornei@....com, linux-kernel@...r.kernel.org,
        horia.geanta@....com, nipun.gupta@....com, tglx@...utronix.de,
        linux-arm-kernel@...ts.infradead.org, jason@...edaemon.net
Subject: Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote:
> diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> index 5904836..1ac8ec6 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> @@ -1,33 +1,8 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */

Hm, I don't think you want to do that.  How can a Linux driver subsytem
that wraps calls to the kernel's driver core (which are GPL-only), be
accessed by BSD-3 code?

If I didn't know any better, I would think you were trying to create a
"GPL Condom" here :)

Anyway, why all of the BSD-3 stuff here?  That makes no sense for kernel
code at all, and this is a relicensing of the file, have you gotten
legal approval of everyone that has modified the file while it was under
the GPL-v2 only text to be able to change it to BSD-3 as well?

Careful, this is a _VERY_ tricky thing to do right.  I need a
signed-off-by on this type of patch from your legal council to ensure
that they know exactly what you are doing, and have reviewed it
properly, before I can take it.

Hint, stick to the existing license in the files, it makes more sense,
you are not going to be taking this code out of Linux and putting it
anywhere.

thanks,

greg k-h