linux-kernel - Re: staging: lustre: lnet: convert selftest to use workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8724a144-6e84-7237-3a0a-21812901d88a@canonical.com>
Date:   Tue, 16 Jan 2018 15:59:58 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        NeilBrown <neilb@...e.com>, lustre-devel@...ts.lustre.org,
        devel@...verdev.osuosl.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: staging: lustre: lnet: convert selftest to use workqueues

Hi,

CoverityScan detected a couple of issues, one of which was introduced
with the following commit:

commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
Author: NeilBrown <neilb@...e.com>
Date:   Thu Jan 11 15:06:40 2018 +1100

CoverityScan CID#1464078 ("Uninitialized scalar variable")

I'm not sure what the expected error return for these conditions are, so
I've not fixed these as I didn't want to hazard a guess.

static int
lnet_selftest_init(void)
{
        int nscheds;
        int rc;

// note here rc is not initialized

        int i;

        lst_serial_wq = alloc_ordered_workqueue("lst_s", 0);
        if (!lst_serial_wq) {
                CERROR("Failed to create serial WI scheduler for LST\n");
                return rc;

// garbage value in rc is returned

        }
        lst_init_step = LST_INIT_WI_SERIAL;

        nscheds = cfs_cpt_number(lnet_cpt_table());
        lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]),
                                        GFP_KERNEL | __GFP_ZERO);
        if (!lst_test_wq)
                goto error;

// this also returns garbage in rc