linux-kernel - Re: [PATCH 1/3] ARM: dts: at91: nattis: use up-to-date mtd partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116163015.GG2678@piout.net>
Date:   Tue, 16 Jan 2018 17:30:15 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: at91: nattis: use up-to-date mtd partitions

Hi,

On 16/01/2018 at 17:08:33 +0100, Peter Rosin wrote:
> The nattis currently relies on the cmdline to correctly configure the
> MTD partition table, and the one given in the device tree is simply
> ignored. Which is fortunate, since the device tree partition table is
> bonkers and does not match reality.
> 

Shouldn't it be simply removed then?

> So, in order to avoid confusion, fix the device tree partition table
> to match what is expected (i.e. what is normally provided on the cmdline).
> In particular, the rootfs partition should be mtd6.
> 
> Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> index 3ea1d26e1c68..4882bd6d38c1 100644
> --- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> +++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> @@ -216,24 +216,29 @@
>  			reg = <0x0 0x40000>;
>  		};
>  
> -		bootloader@...00 {
> -			label = "bootloader";
> -			reg = <0x40000 0x80000>;
> +		barebox@...00 {
> +			label = "barebox";
> +			reg = <0x40000 0x60000>;
>  		};
>  
> -		bootloaderenv@...00 {
> -			label = "bootloader env";
> -			reg = <0xc0000 0xc0000>;
> +		bareboxenv@...00 {
> +			label = "bareboxenv";
> +			reg = <0xc0000 0x40000>;
>  		};
>  
> -		dtb@...000 {
> -			label = "device tree";
> -			reg = <0x180000 0x80000>;
> +		bareboxenv2@...000 {
> +			label = "bareboxenv2";
> +			reg = <0x100000 0x40000>;
> +		};
> +
> +		oftree@...000 {
> +			label = "oftree";
> +			reg = <0x180000 0x20000>;
>  		};
>  
>  		kernel@...000 {
>  			label = "kernel";
> -			reg = <0x200000 0x600000>;
> +			reg = <0x200000 0x500000>;
>  		};
>  
>  		rootfs@...000 {
> -- 
> 2.11.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com