linux-kernel - Re: [PATCH] vxlan: Fix trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116094839.0775faf2@xeon-e3>
Date:   Tue, 16 Jan 2018 09:48:38 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH] vxlan: Fix trailing semicolon

On Tue, 16 Jan 2018 15:03:32 +0000
Luis de Bethencourt <luisbg@...nel.org> wrote:

> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>
> ---
> 
> Hi,
> 
> An other trailing semicolon to remove. 
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  include/net/vxlan.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index f96391e84a8a..ad73d8b3fcc2 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
>  		l4_hdr = ipv6_hdr(skb)->nexthdr;
>  		break;
>  	default:
> -		return features;;
> +		return features;
>  	}
>  
>  	if ((l4_hdr == IPPROTO_UDP) &&

Fixes: 5f35227ea34b ("net: Generalize ndo_gso_check to ndo_features_check")

Acked-by: Stephen Hemminger <stephen@...workplumber.org>