linux-kernel - Re: [PATCH v4] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9607d51a-4382-396c-a4bd-46bbb24ba46e@infradead.org>
Date:   Wed, 17 Jan 2018 11:13:43 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Marcus Folkesson <marcus.folkesson@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Tomohiro Yoshidomi <sylph23k@...il.com>,
        David Herrmann <dh.herrmann@...il.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-input@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] input: pxrc: new driver for PhoenixRC Flight
 Controller Adapter

On 01/17/2018 11:07 AM, Marcus Folkesson wrote:
> This driver let you plug in your RC controller to the adapter and
> use it as input device in various RC simulators.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---

> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
> index f3c2f6ea8b44..18ab6dafff41 100644
> --- a/drivers/input/joystick/Kconfig
> +++ b/drivers/input/joystick/Kconfig
> @@ -351,4 +351,13 @@ config JOYSTICK_PSXPAD_SPI_FF
>  
>  	  To drive rumble motor a dedicated power supply is required.
>  
> +config JOYSTICK_PXRC
> +	tristate "PhoenixRC Flight Controller Adapter"
> +	depends on USB_ARCH_HAS_HCD
> +	select USB

Drop the (first) depends and change "select USB" to "depends on USB".

Argh, there are lots of input/ drivers that do that.  That's bad/wrong.
A driver should not select (enable) an entire subsystem.  If the user had
the subsystem disabled, it should stay that way.

Dmitry, you can expect some patches...

> +	help
> +	  Say Y here if you want to use the PhoenixRC Flight Controller Adapter.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called pxrc.
>  endif

-- 
~Randy