linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180117192301.GV28161@8bytes.org>
Date:   Wed, 17 Jan 2018 20:23:01 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Robin Murphy <robin.murphy@....com>,
        Nate Watterson <nwatters@...eaurora.org>,
        Will Deacon <will.deacon@....com>,
        linux-arm-kernel@...ts.infradead.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Sinan Kaya <okaya@...eaurora.org>
Subject: Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure
 message

On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:

> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
> 
> Thoughts?

That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.


	Joerg