linux-kernel - Re: [Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link error

Open Source and information security mailing list archives

Message-ID: <20180117212103.GA24386@jcrouse-lnx.qualcomm.com>
Date:   Wed, 17 Jan 2018 14:21:03 -0700
From:   Jordan Crouse <jcrouse@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Rob Clark <robdclark@...il.com>, linux-fbdev@...r.kernel.org,
        Wolfram Sang <wsa@...-dreams.de>,
        David Airlie <airlied@...ux.ie>, linux-arm-msm@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Archit Taneja <architt@...eaurora.org>,
        dri-devel@...ts.freedesktop.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-i2c@...r.kernel.org, freedreno@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link
 error

On Mon, Jan 15, 2018 at 05:14:05PM +0100, Arnd Bergmann wrote:
> When NVMEM is configured as a loadable module, and adreno
> is built-in, we get a link failure:
> 
> drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init':
> a5xx_gpu.c:(.text+0x15cc): undefined reference to `nvmem_cell_get'
> a5xx_gpu.c:(.text+0x15da): undefined reference to `nvmem_cell_read'
> a5xx_gpu.c:(.text+0x15e4): undefined reference to `nvmem_cell_put'
> 
> This adds a Kconfig dependency to enforce valid configurations,
> when NVMEM is a loadable module, adreno now has to also be one.
> The code seems to deal fine with nvmem being completely disabled,
> it will just not set the right speed bin then, so we don't need
> a hard dependency.
> 
> Fixes: f56d9df656c4 ("drm/msm/adreno: Read the speed bins for a5xx targets")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Jordan Crouse <jcrouse@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 99d39b2aefa6..74fb1c816da9 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -4,6 +4,7 @@ config DRM_MSM
>  	depends on DRM
>  	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
>  	depends on OF && COMMON_CLK
> +	depends on NVMEM || !NVMEM
>  	depends on MMU
>  	select QCOM_MDT_LOADER if ARCH_QCOM
>  	select REGULATOR
> -- 
> 2.9.0
> 
> _______________________________________________
> Freedreno mailing list
> Freedreno@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives