linux-kernel - Re: [PATCH v2 3/4] Staging: rtl8723bs: Change condition to assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 12:51:30 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 3/4] Staging: rtl8723bs: Change condition to assignment

On Wed, Jan 17, 2018 at 12:33:23AM +0530, Shreeya Patel wrote:
> Change the conditional operator to assignment as it is
> not a conditional statement.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498@...il.com>
> ---
> 
> Changes in v2
>   -Rebase and resend.
> 
>  drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index 00b20c0..314b31f 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -460,7 +460,7 @@ static u32 sdio_read_port(
>  		if (mem == NULL) {
>  			DBG_8192C(KERN_WARNING "%s: allocate memory %d bytes fail!\n", __func__, cnt);
>  			mem = oldmem;
> -			oldmem == NULL;
> +			oldmem = NULL;
>  		}
>  #else

This bug would cause a GCC warning if it were ever compiled.  This
ifdefed code is dead.  We should just delete it.

regards,
dan carpenter