linux-kernel - Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZJjOEandxFeqbnei3bWpsNetWTbnna+7zGi5FofzcS59g@mail.gmail.com>
Date:   Wed, 17 Jan 2018 10:15:10 -0200
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Guo Yi <yi2010.guo@...sung.com>
Cc:     "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

Hi,

On Wed, Jan 17, 2018 at 1:47 AM, Guo Yi <yi2010.guo@...sung.com> wrote:
> This patch fix the bluetooth 6lowpan disconnect fail bug.
>
> The type of the same address type have different define value in HCI layer
> and L2CAP layer.That makes disconnect fail due to wrong network type.User
> will not be able to disconnect from console with the network type that used
> in connect.
>
> This patch add a var lookup_type, and covert the channel address type to
> HCI address type. By these means, user can disconnect successfuly.
>
> Signed-off-by: Guo Yi <yi2010.guo@...sung.com>

While this fix seems alright the debugfs interface was never meant for
production, in fact we are working on a replacement:

https://www.spinics.net/lists/linux-bluetooth/msg72499.html

> ---
>  net/bluetooth/6lowpan.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 795ddd8..332dddb 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -1104,11 +1104,18 @@ static int get_l2cap_conn(char *buf, bdaddr_t *addr, u8 *addr_type,
>         struct hci_dev *hdev;
>         bdaddr_t *src = BDADDR_ANY;
>         int n;
> +       u8 lookup_type;
>
>         n = sscanf(buf, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx %hhu",
>                    &addr->b[5], &addr->b[4], &addr->b[3],
>                    &addr->b[2], &addr->b[1], &addr->b[0],
>                    addr_type);
> +       /* Convert from L2CAP channel address type to HCI address type
> +        */
> +       if (*addr_type == BDADDR_LE_PUBLIC)
> +               lookup_type = ADDR_LE_DEV_PUBLIC;
> +       else
> +               lookup_type = ADDR_LE_DEV_RANDOM;
>
>         if (n < 7)
>                 return -EINVAL;
> @@ -1118,7 +1125,7 @@ static int get_l2cap_conn(char *buf, bdaddr_t *addr, u8 *addr_type,
>                 return -ENOENT;
>
>         hci_dev_lock(hdev);
> -       hcon = hci_conn_hash_lookup_le(hdev, addr, *addr_type);
> +       hcon = hci_conn_hash_lookup_le(hdev, addr, lookup_type);
>         hci_dev_unlock(hdev);
>
>         if (!hcon)
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz