linux-kernel - Re: [PATCH] iommu/omap: Fix debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180117132349.3q4gkabp3rmm2yim@8bytes.org>
Date:   Wed, 17 Jan 2018 14:23:49 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     iommu@...ts.linux-foundation.org, Tony Lindgren <tony@...mide.com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/omap: Fix debugfs_create_*() usage

On Tue, Jan 02, 2018 at 04:29:45PM +0100, Geert Uytterhoeven wrote:
> When exposing data access through debugfs, the correct
> debugfs_create_*() functions must be used, depending on data type.
> 
> Remove all casts from data pointers passed to debugfs_create_*()
> functions, as such casts prevent the compiler from flagging bugs.
> 
> omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
> a part of it.  Fix this by using debugfs_create_u32() instead.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Compile-tested only.
> ---
>  drivers/iommu/omap-iommu-debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.