linux-kernel - Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180117133359.GD3188@kroah.com>
Date:   Wed, 17 Jan 2018 14:33:59 +0100
From:   Greg KH <greg@...ah.com>
To:     ShuFanLee <leechu729@...il.com>
Cc:     heikki.krogerus@...ux.intel.com, cy_huang@...htek.com,
        shufan_lee@...htek.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote:
> +static inline int rt1711h_reg_write_word(struct rt1711h_chip *chip, uint8_t reg,
> +	uint16_t data)
> +{
> +	data = cpu_to_le16(data);
> +	return rt1711h_reg_block_write(chip, reg, 2, (uint8_t *)&data);
> +}

Did you run sparse on this code?  What are you doing casting the types
all over the place for data?  That does not seem correct at all.

thanks,

greg k-h