linux-kernel - Re: [PATCH 32/32] aio: implement io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49fu741tlr.fsf@segfault.boston.devel.redhat.com>
Date:   Wed, 17 Jan 2018 08:51:28 -0500
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     viro@...iv.linux.org.uk, Avi Kivity <avi@...lladb.com>,
        linux-aio@...ck.org, linux-fsdevel@...r.kernel.org,
        netdev@...r.kernel.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 32/32] aio: implement io_pgetevents

Christoph Hellwig <hch@....de> writes:

> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote:
>> I'd be willing to bet the issue is in your io_syscall6 implementation.
>> You pass in arg5 where arg6 should be used.  Don't feel bad, it took me
>> the better part of today to figure that out.  :)
>> 
>> Here's an incremental diff on top of what you've posted.  Feel free to
>> fold it into your patch (and format however you like).  You can find the
>> libaio changes in my 'aio-poll' branch:
>>   https://pagure.io/libaio/commits/aio-poll
>> 
>> These changes were run through the libaio test harness, 64 bit and 32
>> bit, so the compat system call was tested.
>
> Oops, yes.  Although I prefer the copy_from_user version, this is what
> I had:

Much cleaner.

Thanks!
Jeff