linux-kernel - Re: [PATCH] input: remove unneeded DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180117004114.gpy552mfz2jo4fay@dtor-ws>
Date:   Tue, 16 Jan 2018 16:41:14 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org
Subject: Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

On Fri, Nov 17, 2017 at 03:51:31PM +0100, Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference.  For some of these drivers, the #define is just a
> > few lines above the MODULE_LICENSE() line, which is extra pointless.
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: Arvind Yadav <arvind.yadav.cs@...il.com>
> > Reported-by: Philippe Ombredanne <pombredanne@...b.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> 
> Reviewed-by: Philippe Ombredanne <pombredanne@...b.com>

Applied, thank you.

-- 
Dmitry