linux-kernel - Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3e2e046-9a26-39ad-d08f-3715722d7cd9@linaro.org>
Date:   Wed, 17 Jan 2018 16:37:33 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Emil Velikov <emil.l.velikov@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     DRI Development <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state



On 17/01/18 14:36, Emil Velikov wrote:
> On 17 January 2018 at 14:01, Daniel Vetter <daniel.vetter@...ll.ch> wrote:
>> Nothing in the entire tree ever sets this, which means this is dead
>> code. Remove it.
>>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Cc: Daniel Thompson <daniel.thompson@...aro.org>
>> Cc: Jingoo Han <jingoohan1@...il.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
>> ---
>>   drivers/video/backlight/generic_bl.c | 5 -----
> 
> Fly-by comment, while waiting for coffee to kick-in.
> I think this patch should be after pandora/others have stopped abusing
> BL_CORE_DRIVER1.

You sure?

I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver 
should influence another independent driver.


Daniel.