linux-kernel - Re: [PATCH] PCI / PM: Fix trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180117182149.GB7039@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 17 Jan 2018 12:21:49 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH] PCI / PM: Fix trailing semicolon

[+cc Rafael]

On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Rafael, I have nothing queued for pci-driver.c, and you've merged most
of the recent changes there.  If you have any pending changes to it,
feel free to merge this one.  Otherwise, I'll be happy to pick it up.

I would change the subject to:

  PCI / PM: Remove spurious semicolon

> ---
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  drivers/pci/pci-driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index d79dbc377b9c..5958c8dda4e3 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
>  	if (dev_pm_smart_suspend_and_suspended(dev))
>  		return 0;
>  
> -	return pm_generic_freeze_late(dev);;
> +	return pm_generic_freeze_late(dev);
>  }
>  
>  static int pci_pm_freeze_noirq(struct device *dev)
> -- 
> 2.15.1
>