linux-kernel - Re: Suspend/resume with FTRACE enabled doesn’t work anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d7580f4-4b14-1dd2-451d-9c273931748e@molgen.mpg.de>
Date:   Thu, 18 Jan 2018 10:33:07 +0100
From:   Paul Menzel <pmenzel+linux-ftrace@...gen.mpg.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        regressions@...mhuis.info,
        Mario Limonciello <mario.limonciello@...l.com>,
        Len Brown <len.brown@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: Suspend/resume with FTRACE enabled doesn’t work anymore

Dear Steven,


On 01/17/18 17:25, Steven Rostedt wrote:
> On Wed, 17 Jan 2018 11:19:43 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>> On Wed, 17 Jan 2018 11:10:31 -0500
>> Steven Rostedt <rostedt@...dmis.org> wrote:
>>
>>
>>> It's been fixed, and the the patch is in Linus's tree already:
>>>
>>>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0e3a18f4baf8e3754ac1e56f0ade924d0c0c721
>>
>> Although I just noticed that the revert, also reverted the required
>> barriers. I'll go add them back in.
> 
> I take that back. Barriers are not needed, as interrupts do not need to
> see the updates. And looking at the patch being reverted, I don't think
> they were needed there either. The update to those bits only need to be
> done for the current context to prevent recursion at that context. And
> that was the case with the commit that was reverted.

The problem is indeed fixed in latest Linus’ master with commit a0e3a18f 
(ring-buffer: Bring back context level recursive checks). Thank you.


Kind regards,

Paul


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5174 bytes)